Fix: remove sensitive logs #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchapi
commented
Oct 29, 2023
Comment on lines
-65
to
+70
| $em->flush(); | ||
|
|
||
| try { | ||
| $em->flush(); | ||
| } catch (\Exception $e) { | ||
| error_log('IMAP Error (flush): '.$e->getMessage()); | ||
| } |
There was a problem hiding this comment.
Catching the exception will allow to continue (as the auth succeeded) and not log the trace, if any
tchapi
commented
Oct 29, 2023
Comment on lines
-164
to
+168
| $em->flush(); | ||
|
|
||
| try { | ||
| $em->flush(); | ||
| } catch (\Exception $e) { | ||
| error_log('LDAP Error (flush): '.$e->getMessage()); | ||
| } |
There was a problem hiding this comment.
Catching the exception will allow to continue (as the auth succeeded) and not log the trace, if any
tchapi
commented
Nov 1, 2023
Comment on lines
+71
to
+75
|
|
||
| # Logging path | ||
| # By default, it will log in the standard Symfony directory: var/log/prod.log (for production) | ||
| # You can use /dev/null here if you want to discard logs entirely | ||
| LOG_FILE_PATH="%kernel.logs_dir%/%kernel.environment%.log" |
tchapi
force-pushed
the
fix/sensitive-logs
branch
2 times, most recently
from
4f303a4 to
3d2ced0
Compare
tchapi
force-pushed
the
fix/sensitive-logs
branch
from
3d2ced0 to
db1ef33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will filter out passwords from logs, and filter out sensitive arguments from a subset of functions too for safety