Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for user-defined data types (Sybase only) #325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for user-defined data types (Sybase only) #325

wants to merge 2 commits into from

Conversation

vitalca
Copy link
Contributor

@vitalca vitalca commented Nov 7, 2022

Related issue: #323

@jenkins-juliogonzalez
Copy link
Member

Can one of the admins verify this patch?

@vitalca vitalca changed the title Add support for user-defined data types Add support for user-defined data types (Sybase only) Nov 9, 2022
@GeoffMontee
Copy link
Collaborator

Test this, please

@jenkins-juliogonzalez
Copy link
Member

Test PASSed.

@juliogonzalez
Copy link
Member

Let's test it again, and if so, maybe it can be merged.

Test this, please.

@jenkins-juliogonzalez
Copy link
Member

Test PASSed.

@GeoffMontee
Copy link
Collaborator

Hi @vitalca ,

Thanks for the PR! Sorry for letting this one sit for a while.

What do you think about the following changes for this?:

  • Allow different foreign servers to have different keep_untranslatable_types values by changing it from a custom boolean variable to a server option defined in src/options.c
  • Add some documentation for keep_untranslatable_types to ForeignServerCreation.md

@vitalca
Copy link
Contributor Author

vitalca commented Jul 20, 2023

Hi @GeoffMontee,

That makes sense. Thanks for the suggestion!
I am a Java developer, but what you suggested is seemingly easy to implement. Let me give it a try.

@JosefMachytkaNetApp JosefMachytkaNetApp mentioned this pull request Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitalca @jenkins-juliogonzalez @GeoffMontee @juliogonzalez