Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support record comment #910

Merged
merged 28 commits into from
Sep 20, 2024
Merged

feat: support record comment #910

merged 28 commits into from
Sep 20, 2024

Conversation

caoxing9
Copy link
Contributor

@caoxing9 caoxing9 commented Sep 13, 2024 •
edited
Loading

feat: support record comment

  • support link
  • support @ user
  • support image
  • support reaction
  • support notification
  • realtime conversation
comment.mp4

comment-gif

@caoxing9 caoxing9 linked an issue Sep 13, 2024 that may be closed by this pull request
Table comments #835
Closed
@caoxing9 caoxing9 marked this pull request as draft September 13, 2024 09:23
@caoxing9 caoxing9 marked this pull request as ready for review September 16, 2024 14:24
tea-artist
tea-artist approved these changes Sep 18, 2024
View reviewed changes
packages/common-i18n/src/locales/ja/sdk.json Outdated Show resolved Hide resolved
packages/common-i18n/src/locales/ja/sdk.json Outdated Show resolved Hide resolved
@caoxing9 caoxing9 force-pushed the feat/comment branch 5 times, most recently from d332011 to 591b79c Compare September 18, 2024 13:43
@coveralls
Copy link
Collaborator

coveralls commented Sep 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10951910915

Details

  • 618 of 812 (76.11%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on feat/comment at 84.933%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/attachments/plugins/adapter.ts 2 4 50.0%
apps/nestjs-backend/src/features/comment/comment-open-api.controller.ts 131 159 82.39%
apps/nestjs-backend/src/features/notification/notification.service.ts 3 61 4.92%
apps/nestjs-backend/src/features/comment/comment-open-api.service.ts 458 564 81.21%
Totals Coverage Status
Change from base Build 10943358602: 84.9%
Covered Lines: 36770
Relevant Lines: 43293
💛 - Coveralls

@tea-artist
Copy link
Contributor

Let's rock!

This was linked to issues Sep 19, 2024
Comments field type #833
Closed
Cell comments #834
Closed
@caoxing9 caoxing9 force-pushed the feat/comment branch 2 times, most recently from a4ad790 to abda5a3 Compare September 19, 2024 09:47
@caoxing9 caoxing9 closed this Sep 19, 2024
@caoxing9 caoxing9 reopened this Sep 19, 2024
@caoxing9
feat: create comment prisma tempalte
25d9a98
@caoxing9
feat: generate comment open-api
0d8ab63
@caoxing9
feat: support comment advance feature
3b9ace1
@caoxing9
feat: comment notify user list add quote creator and mention user
a88c6fb
@caoxing9
feat: grid support display comment count
e5d3bdd
@caoxing9
chore: add comment e2e test suit
2343129
@caoxing9
fix: fix type definition clash
0dfbe5f
@caoxing9
chore: add comment migration
7720653
@caoxing9
fix: separate partial comment type definition for zod2openapi unknown…
b751791 
… error
@caoxing9
fix: import @teable/icons error when moduleResolution set to `Bun…
a7be107 
…dler`
@caoxing9
fix: sdk i18n error code
e231c3e
@caoxing9
feat: rename comment subscribe table name and generate migration
4dc6af9
@caoxing9
feat: add comment reaction thumbsdown
e173a00
@caoxing9
fix: add presence unsubscribe judgment relative to comment
33b396c
@caoxing9
chore: css adjustment
f09e913 
fix: zod2openapi error by separate type define
@caoxing9
fix: comment e2e error
b0d0f40
@caoxing9
feat: add composite index for comment list table
45ef062
@caoxing9
feat: add record comment count query api
ea73dad
@caoxing9
fix: reply to someone should be receive the notification
d4a6cdd
@caoxing9
fix: comment count inaccurate when add view group condition
0e744c0
@caoxing9
fix: abundant field expand card display
c0cd528
@caoxing9
feat: @ mention user filter self
f01e1da
@caoxing9
fix: not found subscribe throw null
014b47d
@caoxing9 caoxing9 merged commit 5cf73f2 into develop Sep 20, 2024
8 checks passed
@caoxing9 caoxing9 deleted the feat/comment branch September 20, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boris-w boris-w boris-w left review comments

@tea-artist tea-artist tea-artist approved these changes

@Sky-FE Sky-FE Sky-FE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table comments Cell comments Comments field type
5 participants
@caoxing9 @coveralls @tea-artist @Sky-FE @boris-w