feat(xdesign-story): button component 추가 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jikwan0327
requested review from
eungyeole,
syi0808,
oajh04,
jidole02 and
jcho0216
as code owners
eungyeole
approved these changes
Aug 21, 2023
| import styled from '@emotion/styled'; | ||
| import { ButtonVarientType, ButtonKindType, ButtonProps } from './Button.types'; | ||
|
|
||
| export const Button = ({ varient, kind, icon, children, ...props }: ButtonProps) => { |
There was a problem hiding this comment.
button에 forwardRef 감싸서 ref를 받을수 있으면 좋을 것 같아
There was a problem hiding this comment.
수정은 했습니다만 제가 맞게 한 건지 확신이 안들어서 그러는데 재확인 부탁드려도 될까요?
Comment on lines
29
to
48
| const kindVarient = (kind: ChipKindType) => { | ||
| switch (kind) { | ||
| case 'filled': | ||
| return css` | ||
| color: ${lightTheme.OnSecondary}; | ||
| background: ${lightTheme.Secondary}; | ||
| `; | ||
| case 'outlined': | ||
| return css` | ||
| color: ${lightTheme.Secondary}; | ||
| background-color: ${lightTheme.OnSecondary}; | ||
| border: 1px solid ${lightTheme.Secondary}; | ||
| &:active { | ||
| color: ${lightTheme.Secondary}; | ||
| background-color: ${lightTheme.SecondaryContainer}; | ||
| } | ||
| `; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
lightTheme의 컬러를 가져오는 것 같은데 나중에 다크모드를 추가하면 문제가 되지 않을까?
There was a problem hiding this comment.
제가 잘 이해가 되지 않아서 그러는데 어떠한 부분에서 문제가 될 수 있는지 설명해 주실 수 있나요?
There was a problem hiding this comment.
@jikwan0327 다크모드 상태일때도 라이트 모드의 색깔이 나오지 않을까 해서요?
There was a problem hiding this comment.
다크모드 추가하여 확장가능하도록 변경하여 올렸습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
좋습니다.
작업사항
참조