YEL-88 [fix] 투표 생성 응답값 수정

team-yello · Aug 7, 2023 · 657a4df · 657a4df
2 parents 85bdfe9 + 5b12685
commit 657a4df
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 18 deletions.
diff --git a/src/main/java/com/yello/server/domain/vote/controller/VoteController.java b/src/main/java/com/yello/server/domain/vote/controller/VoteController.java
@@ -144,7 +144,9 @@ public BaseResponse<VoteCreateResponse> createVote(
     ) {
         val data = voteService.createVote(user.getId(), request);
         data.votes().forEach(notificationService::sendYelloNotification);
-        return BaseResponse.success(CREATE_VOTE_SUCCESS, data.toOnlyPoint());
+
+        val response = VoteCreateResponse.of(data.point());
+        return BaseResponse.success(CREATE_VOTE_SUCCESS, response);
     }
 
     @Operation(summary = "투표 이름 부분 조회 API", responses = {

diff --git a/src/main/java/com/yello/server/domain/vote/dto/response/VoteCreateResponse.java b/src/main/java/com/yello/server/domain/vote/dto/response/VoteCreateResponse.java
@@ -1,23 +1,13 @@
 package com.yello.server.domain.vote.dto.response;
 
-import com.yello.server.domain.vote.entity.Vote;
-import java.util.List;
 import lombok.Builder;
 
 @Builder
 public record VoteCreateResponse(
-    Integer point,
-    List<Vote> votes
+    Integer point
 ) {
 
-    public static VoteCreateResponse of(Integer point, List<Vote> votes) {
-        return VoteCreateResponse.builder()
-            .point(point)
-            .votes(votes)
-            .build();
-    }
-
-    public VoteCreateResponse toOnlyPoint() {
+    public static VoteCreateResponse of(Integer point) {
         return VoteCreateResponse.builder()
             .point(point)
             .build();

diff --git a/src/main/java/com/yello/server/domain/vote/dto/response/VoteCreateVO.java b/src/main/java/com/yello/server/domain/vote/dto/response/VoteCreateVO.java
@@ -0,0 +1,19 @@
+package com.yello.server.domain.vote.dto.response;
+
+import com.yello.server.domain.vote.entity.Vote;
+import java.util.List;
+import lombok.Builder;
+
+@Builder
+public record VoteCreateVO(
+    Integer point,
+    List<Vote> votes
+) {
+
+    public static VoteCreateVO of(Integer point, List<Vote> votes) {
+        return VoteCreateVO.builder()
+            .point(point)
+            .votes(votes)
+            .build();
+    }
+}
diff --git a/src/main/java/com/yello/server/domain/vote/service/VoteService.java b/src/main/java/com/yello/server/domain/vote/service/VoteService.java
@@ -32,7 +32,7 @@
 import com.yello.server.domain.vote.dto.request.VoteAnswer;
 import com.yello.server.domain.vote.dto.response.RevealNameResponse;
 import com.yello.server.domain.vote.dto.response.VoteAvailableResponse;
-import com.yello.server.domain.vote.dto.response.VoteCreateResponse;
+import com.yello.server.domain.vote.dto.response.VoteCreateVO;
 import com.yello.server.domain.vote.dto.response.VoteDetailResponse;
 import com.yello.server.domain.vote.dto.response.VoteFriendResponse;
 import com.yello.server.domain.vote.dto.response.VoteListResponse;
@@ -140,7 +140,7 @@ public VoteAvailableResponse checkVoteAvailable(Long userId) {
     }
 
     @Transactional
-    public VoteCreateResponse createVote(Long userId, CreateVoteRequest request) {
+    public VoteCreateVO createVote(Long userId, CreateVoteRequest request) {
         List<Vote> votes = new ArrayList<>();
         final User sender = userRepository.getById(userId);
 
@@ -170,7 +170,7 @@ public VoteCreateResponse createVote(Long userId, CreateVoteRequest request) {
         }
 
         sender.plusPoint(request.totalPoint());
-        return VoteCreateResponse.of(sender.getPoint(), votes);
+        return VoteCreateVO.of(sender.getPoint(), votes);
     }
 
     @Transactional

diff --git a/src/test/java/com/yello/server/small/domain/vote/VoteServiceTest.java b/src/test/java/com/yello/server/small/domain/vote/VoteServiceTest.java
@@ -20,7 +20,7 @@
 import com.yello.server.domain.vote.dto.request.VoteAnswer;
 import com.yello.server.domain.vote.dto.response.RevealNameResponse;
 import com.yello.server.domain.vote.dto.response.VoteAvailableResponse;
-import com.yello.server.domain.vote.dto.response.VoteCreateResponse;
+import com.yello.server.domain.vote.dto.response.VoteCreateVO;
 import com.yello.server.domain.vote.dto.response.VoteDetailResponse;
 import com.yello.server.domain.vote.dto.response.VoteFriendResponse;
 import com.yello.server.domain.vote.dto.response.VoteListResponse;
@@ -323,7 +323,7 @@ void init() {
             .build();
 
         // when
-        VoteCreateResponse result = voteService.createVote(userId, request);
+        VoteCreateVO result = voteService.createVote(userId, request);
 
         // then
         assertThat(result.point()).isEqualTo(2003);