YEL-176 [feat] 오류 수정 및 로그 추가

team-yello · Oct 15, 2023 · 8263125 · 8263125
1 parent c5188da
commit 8263125
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/main/java/com/yello/server/domain/purchase/dto/request/google/DeveloperNotification.java b/src/main/java/com/yello/server/domain/purchase/dto/request/google/DeveloperNotification.java
@@ -20,7 +20,7 @@ public record DeveloperNotification(
 ) {
 
     public ProductType getProductType() {
-        if (ObjectUtils.isEmpty(testNotification)) {
+        if (!ObjectUtils.isEmpty(testNotification)) {
             return ProductType.TEST;
         } else if (!ObjectUtils.isEmpty(subscriptionNotification)) {
             return ProductType.YELLO_PLUS;

diff --git a/src/main/java/com/yello/server/domain/purchase/service/PurchaseService.java b/src/main/java/com/yello/server/domain/purchase/service/PurchaseService.java
@@ -328,7 +328,7 @@ public void appleNotification(AppleNotificationRequest request) {
 
         AppleNotificationPayloadVO payloadVO =
             purchaseManager.decodeApplePayload(request.signedPayload());
-        
+
         ApplePurchaseVO purchaseData = purchaseManager.getPurchaseData(payloadVO);
         purchaseRepository.findByTransactionId(purchaseData.transactionId())
             .ifPresent((purchase) -> {
@@ -356,6 +356,7 @@ public void appleNotification(AppleNotificationRequest request) {
     @Transactional
     public void googleNotification(GooglePubSubNotificationRequest request) {
         if (!Objects.equals(request.subscription(), googlePubSubName)) {
+            log.info("BAD REQUEST by wrong pub-sub name");
             throw new GoogleBadRequestException(GOOGLE_NOTIFICATION_BAD_REQUEST_EXCEPTION);
         }
 
@@ -368,8 +369,10 @@ public void googleNotification(GooglePubSubNotificationRequest request) {
 
         final DeveloperNotification developerNotification = gson.fromJson(data, DeveloperNotification.class);
         if (ObjectUtils.isEmpty(developerNotification.getProductType())) {
+            log.info("BAD REQUEST by wrong pub-sub name");
             throw new GoogleBadRequestException(GOOGLE_NOTIFICATION_BAD_REQUEST_EXCEPTION);
         }
+        log.info(String.format("notification product type is %s", developerNotification.getProductType().toString()));
 
         final Optional<Purchase> purchase = purchaseRepository.findByPurchaseToken(
             developerNotification.subscriptionNotification().purchaseToken());