YEL-181 [feat] Notice, UserData entity 추가 #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeonjeongs
approved these changes
Jan 7, 2024
Comment on lines
+26
to
+30
| @Column(nullable = false) | ||
| private ZonedDateTime startDate; | ||
|
|
||
| @Column(nullable = false) | ||
| private ZonedDateTime endDate; |
There was a problem hiding this comment.
LocalDateTime이 아닌 ZonedDateTime으로 설정하신 이유가 있나요?
둘의 어떤 차이로 인해 결정한것인가요?
There was a problem hiding this comment.
public final class ZonedDateTime implements Temporal, ChronoZonedDateTime<LocalDate>, Serializable {
...
private final LocalDateTime dateTime;
private final ZoneOffset offset;
private final ZoneId zone;
...ZonedDateTime의 구현체를 보면, LocalDateTime과 ZoneOffset, ZoneId의 Composition으로 이루어져 있는데,
이는 Java가 실행되는 컴퓨터(Local)에 의해 시간값의 상태가 달라지는 LocalDateTime의 문제를 해결하기 위해서 설계되었음.
컴퓨터의 시간대가 UTC(+0)으로 설정되어있으면, LocalDateTime 시간 기준은 UTC(+0)으로 값을 저장하게 됨.
우리는 한국시간대 KST(+9)을 기준으로 프로그램을 설계해야하기 때문에, ZonedDateTime으로 필드를 구성하였음.
활용법은 아래와 같이 활용하면 되니 레퍼런스 확인해주시면 감사링
final ZoneId SouthKoreaZoneId = ZoneId.of("Asia/Seoul");
final ZonedDateTime current = ZonedDateTime.now(SouthKoreaZoneId);
current.format(DateTimeFormatter.ISO_LOCAL_DATE); // 2024-01-07
Comment on lines
+12
to
+13
| @Entity | ||
| @Getter |
There was a problem hiding this comment.
@AllArgsConstructor
@NoArgsConstructor(access = AccessLevel.PROTECTED)
@builder
어노테이션도 추가해야하지 않을까요?!
Comment on lines
+12
to
+13
| @Entity | ||
| @Getter |
There was a problem hiding this comment.
Suggested change
| @Entity | |
| @Getter | |
| @Entity | |
| @Getter | |
| @AllArgsConstructor | |
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | |
| @Builder |
Comment on lines
+14
to
+15
| @Getter | ||
| @Entity |
There was a problem hiding this comment.
Suggested change
| @Getter | |
| @Entity | |
| @Getter | |
| @Entity | |
| @Builder | |
| @AllArgsConstructor | |
| @NoArgsConstructor(access = AccessLevel.PROTECTED) |
Comment on lines
+14
to
+15
| @Getter | ||
| @Entity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☘️ Related Issue
✅ Work description
💡 PR point