Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YEL-220 [feat] 광고 보고 보상얻기 가능 여부 조회 #454

Merged
merged 5 commits into from
Feb 17, 2024

Conversation

hyeonjeongs
Copy link
Member

@hyeonjeongs hyeonjeongs commented Feb 16, 2024

☘️ Related Issue

  • resolves YEL-220

✅ Work description

  • 광고 보고 보상얻기 로직 (투표와 동일)
  • 광고 verify시 querystring null 인 경우, 404 에러로 처리

💡 PR point

@hyeonjeongs hyeonjeongs added the feat 새로운 기능 구현 label Feb 16, 2024
@hyeonjeongs hyeonjeongs self-assigned this Feb 16, 2024
Copy link

github-actions bot commented Feb 16, 2024

Test Results

158 tests   158 ✅  9s ⏱️
 26 suites    0 💤
 26 files      0 ❌

Results for commit 8b7727e.

♻️ This comment has been updated with latest results.

Copy link
Member

@euije euije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고~생했다

@@ -71,6 +74,10 @@ public BaseResponse<EventRewardResponse> rewardEvent(@AccessTokenUser User user,
public ResponseEntity<?> verifyAdmob(HttpServletRequest request) {
URI uri;
System.out.println(request.getQueryString() + " alalalalalal");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타인거 같은데 지워주세용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 verify할 때 signature, keyId 확인하려고 테스트겸 넣은거예욤 서버에서 로그로 확인하려구요

@GetMapping("/v1/admob/possible/{tag}")
public BaseResponse<GetIsPossibleAdmob> getIsPossibleAdmob(@AccessTokenUser User user,
@PathVariable("tag") String tag) {
System.out.println(" asfsaasdfasdf");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타인거 같은데 지워주세용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵~

@hyeonjeongs hyeonjeongs merged commit 73db631 into develop Feb 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능 구현 현정👕
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants