feat: store dependencies graph in component model #9214
+7,954
−6,483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
requested changes
Nov 7, 2024
scopes/component/component-writer/component-writer.main.runtime.ts
Outdated
Show resolved
Hide resolved
scopes/component/component-writer/component-writer.main.runtime.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+958
to
+959
| consumerComponents: ConsumerComponent[], | ||
| components: Component[] |
There was a problem hiding this comment.
maybe switch the args order here so it will be same as the order in tagModelComponent args
There was a problem hiding this comment.
tagModelComponent has a single options argument.
src/scope/models/version.ts
Outdated
|
|
||
| export type DependenciesGraph = { | ||
| schemaVersion: string; | ||
| directDependencies: DirectDependency[]; |
There was a problem hiding this comment.
what are the direct deps represent? like the policy of the workspace.jsonc?
| nodeId: string; | ||
| }; | ||
|
|
||
| export type DependenciesGraph = { |
There was a problem hiding this comment.
I would consider making this a class and not just a type, so you can make an API for it.
There was a problem hiding this comment.
Also maybe make it an instance of clear graph? or a composition of cleargraph (so you will put the node and edges inside on a cleargraph instance, then you can make APIs that calls cleargraph internally)
GiladShoham
requested changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Example of the dependencies graph object: https://gist.github.com/zkochan/1ef61728cf8605d7e9e6832a684d5b2f
TODO:
don't write node_modules in e2e tests. We only need the lockfile.no way to skip install as next steps failin e2e tests skip preview in tagged componentspreviews are disabled in e2e tests by default