fix: public router adhere to LogHealthAndMetrics option #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to the admin routes, the public router does not disable logging on the health endpoints. This change alters the behaviour of the public router to be in line with the admin router.
lfleischmann
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In contrast to the admin routes, the public router does not disable logging on the health endpoints.
This means that if using the public endpoints for health checking, logs will be spammed with health check requests.
With this pull request the "LogHealthAndMetrics" configuration option is now correctly observed also for the public router.
Implementation
Used the admin router implementation and implemented the same solution for the public router.