Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix niteoweb/pyramid_heroku#22] Add request_id... #38

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Fix niteoweb/pyramid_heroku#22] Add request_id... #38

wants to merge 3 commits into from

Commits on Sep 10, 2019

  1. [Fix teamniteo#22] Add request_id... 

    ... to sentry and structlog logs

Signed-off-by: Sourya Vatsyayan <[email protected]>
    @sourya-deepsource
    sourya-deepsource committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    6c764bd View commit details
    Browse the repository at this point in the history

  2. Use sentry_sdk instead of mocked sentry 

    Mocking module imports doesn't go along well with pytest.
sys.modules doesn't remain the same throughout. Besides,
the previous implementation used global vars in tests, which
is not really recommended.

Signed-off-by: Sourya Vatsyayan <[email protected]>
    @sourya-deepsource
    sourya-deepsource committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    dd7140c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. Conditionally remove sentry_sdk and structlog in tests 

    This brings up test coverage to 100%. B-)
Also, add type hints in some functions and the global vars.

Signed-off-by: Sourya Vatsyayan <[email protected]>
    @sourya-deepsource
    sourya-deepsource committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    a4448a9 View commit details
    Browse the repository at this point in the history