Merge pull request #4 from hoegertn/hoegertn-fixes

feat: some improvements
teamplanes · Feb 19, 2021 · 144476c · 144476c
2 parents d47ef8f + 288f0aa
commit 144476c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/src/WatchableNodejsFunction.ts b/src/WatchableNodejsFunction.ts
@@ -35,10 +35,10 @@ class WatchableNodejsFunction extends NodejsFunction {
       bundle: true,
       entryPoints: [entry],
       platform: 'node',
-      minify: props.bundling?.minify,
+      minify: props.bundling?.minify ?? false,
       sourcemap: props.bundling?.sourceMap,
       external: [
-        ...(props.bundling?.externalModules ?? []),
+        ...(props.bundling?.externalModules ?? ['aws-sdk']),
         ...(props.bundling?.nodeModules ?? []),
       ],
       loader: props.bundling?.loader as {[ext: string]: Loader} | undefined,

diff --git a/src/utils/initAwsSdk.ts b/src/utils/initAwsSdk.ts
@@ -2,7 +2,9 @@ import * as AWS from 'aws-sdk';
 
 export const initAwsSdk = (region: string, profile?: string): void => {
   AWS.config.region = region;
-  AWS.config.credentials = new AWS.SharedIniFileCredentials({
-    profile,
-  });
+  if (profile) {
+    AWS.config.credentials = new AWS.SharedIniFileCredentials({
+        profile,
+    });    
+  }
 };
diff --git a/src/utils/resolveLambdaDetailsFromManifest.ts b/src/utils/resolveLambdaDetailsFromManifest.ts
@@ -7,7 +7,7 @@ const resolveLambdaDetailFromManifest = async (
   detail: CloudFormation.StackResourceDetail;
   lambdaManifest: LambdaManifestType;
 }> => {
-  const cfn = new CloudFormation();
+  const cfn = new CloudFormation({maxRetries: 10});
   const lambdaStackName = await lambdaManifest.nestedStackLogicalIds.reduce(
     (promise, nextNestedStack) =>
       promise.then((stackName) =>

diff --git a/src/utils/updateLambdaFunctionCode.ts b/src/utils/updateLambdaFunctionCode.ts
@@ -6,7 +6,7 @@ export const updateLambdaFunctionCode = async (
   watchOutdir: string,
   detail: CloudFormation.StackResourceDetail,
 ): Promise<PromiseResult<Lambda.FunctionConfiguration, AWSError>> => {
-  const lambda = new Lambda();
+  const lambda = new Lambda({maxRetries: 10});
   return zipDirectory(watchOutdir).then((zip) => {
     return lambda
       .updateFunctionCode({