Skip to content

Commit

Permalink
Do not strengthen module type!
Browse files Browse the repository at this point in the history
  • Loading branch information
jfrolich committed Sep 7, 2020
1 parent b697b83 commit 546e15f
Show file tree
Hide file tree
Showing 8 changed files with 51 additions and 131 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ npm-debug.log
*.cmj
*.cmt
.vscode
.vim
18 changes: 17 additions & 1 deletion documentation/docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,23 @@ title: Changelog
(_Tags are copied from
[babel](https://github.com/babel/babel/blob/master/CHANGELOG.md)_)

## [1.0.0](https://github.com/reasonml-community/graphql_ppx/compare/legacy...master) (in beta)
## [1.0.1](https://github.com/reasonml-community/graphql_ppx/compare/v1.0.0...v1.0.1) (2020-09-07)

- :bug: remove `@ppxConfig` directive from query output
([b697b83](https://github.com/reasonml-community/graphql_ppx/commit/b697b83))

- :bug: do not strengthen module type of extended module to prevent type errors
like below when the the definition is being extended
([4ae9895](https://github.com/reasonml-community/graphql_ppx/commit/4ae9895))

```
This has type:
MyQuery.t_variables
But somewhere wanted:
MyQuery.MyQuery_inner.t_variables
```

## [1.0.0](https://github.com/reasonml-community/graphql_ppx/compare/v0.7.2...v1.0.0) (2020-09-06)

There has been a lot of new features in version 1.0 of `graphql-ppx`. Below some
of the main changes. After 1.0 we are going to record a more detailed changelog.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@reasonml-community/graphql-ppx",
"version": "1.0.0",
"version": "1.0.1",
"description": "graphql-ppx rewriter for Bucklescript/ReasonML",
"repository": "https://github.com/reasonml-community/graphql-ppx",
"author": "Tomasz Cichocinski <[email protected]>",
Expand Down
21 changes: 20 additions & 1 deletion src/bucklescript/output_bucklescript_module.re
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,26 @@ let wrap_query_module =
let signature =
List.concat([
[signature_module(module_name, signature)],
signature,
[
Sig.include_(
Incl.mk(
Mty.typeof_(
Mod.mk(
Pmod_structure([
Str.include_(
Incl.mk(
Mod.ident({
txt: Longident.parse(module_name),
loc,
}),
),
),
]),
),
),
),
),
],
[
Sig.include_(
Incl.mk(
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 546e15f

Please sign in to comment.