This repository has been archived by the owner on Nov 20, 2019. It is now read-only.
feature/encapsulate-Tests-field #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, will take a look soon-ish. |
|
OK. Sorry but super busy - will try to have a look soon. |
tebeka
reviewed
Oct 13, 2016
| } | ||
|
|
||
| // AddTest adds a test case to the suite | ||
| func (suite *Suite) AddTest(test *Test) { |
There was a problem hiding this comment.
I'm note sure I like this change. I don't see value in hiding the data structure implementation when it's internal. I don't think the extra code is worth it and that it's not idiomatic Go IMO.
If we'd expose some data structures as an API (see #39 ) then we might make Suite and Test an interface.
Am I missing something?
There was a problem hiding this comment.
This change is part of a bigger local refactoring branch. Unfortunately, it has not come to fruition yet, so I thought I will commit and PR early.
|
As it stands, this PR is not valuable (see @tebeka comment above). Closing it for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.