build(TA-439): update design language guidance regarding character limits #36
Conversation
| <li> | ||
| Allow the user to enter more characters than the maximum limit. The form validation will handle any excess. | ||
| </li> | ||
| </ul> |
There was a problem hiding this comment.
I've tried to capture things correctly from here, but not 100% sure I have.
There was a problem hiding this comment.
I think I'd try to include the line "Only use the character count component when there is a good reason for limiting the number of characters users can enter".
So maybe it could be that followed by "when using this component you should:"
| "serve": "14.1.1", | ||
| "standard-version": "9.5.0", | ||
| "stylelint": "15.2.0", | ||
| "stylelint-config-twbs-bootstrap": "7.0.0" |
There was a problem hiding this comment.
Fixing these in place solved issues when running npm i and is what we do in repos like otis.
|
There were a good few files changed when I ran npm start, I assume this is supposed to happen? I can remove the updates in those places if needed. |
| @@ -34,34 +34,34 @@ | |||
| </button> | |||
| <div class="collapse navbar-collapse" id="navbarSupportedContent"> | |||
| <ul class="navbar-nav ms-auto mb-2 mb-lg-0"> | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
What's with all the whitespace changes?
There was a problem hiding this comment.
I'm not too sure, the line numbers seem to be the same for both the removed and added
Problem
We have been having discussions to update the branding configuration screen. We need to make changes to the current guidance regarding character limits.
Change/Fix
Updated point 5 to match what we now what to follow.
Updated wording of point 7 to match what we currently do - optional by default, marked as required when needed.
Altered the dependencies to resolve issues with running npm i on the repo.