Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TA-1365): update navbar-brand positioning #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(TA-1365): update navbar-brand positioning #47

wants to merge 2 commits into from

Conversation

klaudija-lawrence
Copy link

@klaudija-lawrence klaudija-lawrence commented Oct 17, 2024 •
edited
Loading

Problem

https://techfromsage.atlassian.net/browse/TA-1365

Otis needs to have new branding applied. Whilst implementing this we have noticed that the navbar logo hover/focus styles need improvement.

Example

Before:
image

After (focus):
image

After (hover):
image

Change/Fix

  • Updated positioning of navbar logo to improve focus styles
  • Removed outline on hover

Checklist

@klaudija-lawrence klaudija-lawrence added the 90% 90% PR label Oct 17, 2024
@klaudija-lawrence klaudija-lawrence self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pogotc pogotc Awaiting requested review from pogotc

@darren-arbon darren-arbon Awaiting requested review from darren-arbon

At least 1 approving review is required to merge this pull request.

Assignees

@klaudija-lawrence klaudija-lawrence

Labels
90% 90% PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@klaudija-lawrence