feat(TA-1696): set cors allow credentials optionally (#90)

techfromsage · Oct 8, 2024 · 3d32a4a · 3d32a4a
1 parent d5f3b65
commit 3d32a4a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/lib/authenticated-api/authenticated-api-props.ts b/lib/authenticated-api/authenticated-api-props.ts
@@ -19,6 +19,7 @@ export interface AuthenticatedApiProps {
   domainName: string;
   certificateArn: string;
   corsDomain?: string[];
+  corsAllowCredentials?: boolean;
 
   // Access logs via CloudWatch log group
   logging?: {

diff --git a/lib/authenticated-api/authenticated-api.ts b/lib/authenticated-api/authenticated-api.ts
@@ -55,7 +55,7 @@ export class AuthenticatedApi extends Construct {
         corsPreflight: {
           allowHeaders: ["*"],
           allowMethods: [apigatewayv2_alpha.CorsHttpMethod.ANY],
-          allowCredentials: true,
+          allowCredentials: props.corsAllowCredentials ?? true,
           allowOrigins: props.corsDomain,
         },
       }),

diff --git a/test/infra/authenticated-api/authenticated-api.test.ts b/test/infra/authenticated-api/authenticated-api.test.ts
@@ -99,6 +99,15 @@ describe("AuthenticatedApi", () => {
         {
           Name: "test-MyTestAuthenticatedApi",
           ProtocolType: "HTTP",
+          CorsConfiguration: {
+            AllowCredentials: true,
+            AllowHeaders: ["*"],
+            AllowMethods: ["*"],
+            AllowOrigins: [
+              "http://localhost:4200",
+              `https://test-simple-authenticated-api.talis.com`,
+            ],
+          },
         },
       );
     });