90%: Treat tables, views, and search differently #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this mean? (search indexes are done via some other mechanism) |
| { | ||
| $collection->deleteIndexes(); | ||
| } | ||
| $collection->ensureIndex($indexes, array("background"=>$background)); |
There was a problem hiding this comment.
We should use sparse='true' here to save disk space
|
Search indexes in config are defined differently than the other specs and were never covered under this method. That said, it probably makes sense to force an ensureIndexes to _id.type on the search doc collections just like the others, will do. |
|
Ah, actually, search documents don't define indexes because we only search via regex, so they'd be useless, anyway. Good reason for not merging tables and search documents, honestly. |
rsinger
added a commit
that referenced
this pull request
May 21, 2015
…sources 90%: Treat tables, views, and search differently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found when working on #56 that IndexUtils wasn't properly updated to deal with multiple datasources, which causes failures when it runs across tablespecs, viewspecs, and search document specs.
This branch excludes views, search, and table indexes from the regular index regeneration process and then specifically handles views and table rows (search indexes are done via some other mechanism).