-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Satellite region]: add IAM permissions for supporting feature service running in satellite region #56
base: master
Are you sure you want to change the base?
Conversation
…e running in satellite region
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bunch of nits as I usually get the same comments from @scottames.
@@ -19,6 +19,25 @@ resource "aws_iam_role_policy_attachment" "emr_cross_account_policy_attachment" | |||
role = aws_iam_role.cross_account_role.name | |||
} | |||
|
|||
# CROSS ACCOUNT SATELLITE SERVING | |||
resource "aws_iam_policy" "emr_cross_account_satellite_region_policy" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename this to emr_cross_account_satellite_region since this is aws_iam_policy already
}) | ||
tags = local.tags | ||
} | ||
resource "aws_iam_role_policy_attachment" "emr_cross_account_satellite_region_policy_attachment" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here rename to emr_cross_account_satellite_region since it's already policy_attachment by resource
@@ -63,3 +63,20 @@ resource "aws_iam_role_policy_attachment" "common_spark_policy_attachment" { | |||
policy_arn = aws_iam_policy.common_spark_policy.arn | |||
role = local.spark_role_name | |||
} | |||
|
|||
resource "aws_iam_policy" "satellite_region_policy" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
}) | ||
tags = local.tags | ||
} | ||
resource "aws_iam_role_policy_attachment" "satellite_region_policy_attachment" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
What
add IAM permissions for supporting feature service running in satellite region
Why
Tecton requires extra IAM permissions to set up feature serving stack running in satellite region