Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Some updates #18

wants to merge 3 commits into from

Conversation

ailin-nemui
Copy link

  • multi team in one script
  • rename /mark because it conflicts with another script
  • provide an automark setting to disable mark
  • make Mozilla::CA optional (degrade missing CA to a warning)
  • add NO_ACT level to history (so it will not light up in Act:)
  • get private message history also
  • remove duplicate timestamp from history format

@tedski
Copy link
Owner

tedski commented Apr 26, 2016

Lots of work here! This is great!

Since we currently have no automated testing for this, can you outline your test procedure for these changes? Thanks!

@ailin-nemui
Copy link
Author

Would need feedback from some people actually using it with multiple teams. @mikegrb?

I could not test the multi team support with multiple teams, I only have one (so it still works for 1 team hehe)

I tested that message history for PMs works

All the other changes should be straight forward (just an early escape for the mark command, some added constants)

@ailin-nemui
Copy link
Author

if you want to test it, /set slack_automark off and check if slack still marks messages,

/set slack_token team1:xoxp-.... team2:xoxp-... see if slack script fetches history for both slacks

@ailin-nemui
Copy link
Author

ailin-nemui commented Apr 26, 2016

add NO_ACT level to history (so it will not light up in Act:)

if you freshly start irssi and /connect to your slack, the Act: bar should not be full with red numbers anymore

get private message history also

open a query to someone, history should be loaded

remove duplicate timestamp from history format

slack history should not have duplicate timestamps anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants