Fix bug in which we could not insert images or links using the editor

[JavierGelatti]

Problem

Editing description to insert external link and images is not working on Teespring.

Steps to reproduce

1. Go to the listing page in your seller dashboard.
2. Find any listing (created in Composer or Launcher) and click on the "pencil" icon for "edit". (ie: https://teespring.com/campaigns/72696073/edit)
3. In this view, try to add in a hyperlink or an image by clicking on the buttons.

Expected behavior

• You are able to add images and hyperlinks through our description tool editor

Actual behavior

• The buttons do not respond, and you are not able to add images or hyperlinks through listing edits or Admin campaign pages.

Found issue

When we click on buttons "insert link" or "insert image", the following JS error was raised:
Uncaught TypeError: Failed to execute 'focus' on 'HTMLElement': parameter 1 ('options') is not an object..

This was a known issue, that was fixed in newer versions of the bootstrap-wysihtml5 gem (see: jhollingworth/bootstrap-wysihtml5#391). Currently, we are using a fork from the 0.3.1.24 version, and the latest version of the original gem is 0.3.3.8

Solution

As we on Teespring are using a fork of that gem, upgrading the gem is not direct. Also, I tried to upgrade the gem locally (using the original gem instead of the fork), but there were a bunch of errors during upgrade that we'd need to solve.

So, I decided to solve the problem manually on our fork of the gem.
The problem was solved by replacing element.focus(false) calls with element.focus({}), because the focus function expects an object as its argument (see: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus and jhollingworth/bootstrap-wysihtml5#391 (comment)).

Additional changes

While testing this, @helenlam requested the following:

• Change the text 'Insert image' to 'Insert image URL'.
• Make 'http://' a placeholder, instead of the actual initial value of the fields.

Those changes are also included in this PR, in separate commits.

Link to ticket

https://www.pivotaltracker.com/story/show/162432786

[niklasnordlund]

wysi, wysi, wysi, wizard!

[todditron]

Did anyone find this patch breaks the ability to edit existing links? Not that the edit link functionality worked all that well before, but at least it would clear the link and let you place a new one ...

I get Uncaught TypeError: Cannot read property 'text' of null