Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editor switch entities #3236 #90

Conversation

teeworlds-mirror
Copy link
Collaborator

@ChillerDragon
Copy link
Member

This is a feature. But not touching gameplay, art style, physics, or network protocol. I think this could be merged in teeworlds-community.

@ChillerDragon
Copy link
Member

ChillerDragon commented Mar 1, 2024

Oy expressed his opinion to reject all work done on the editor. In favor of the editor2 project. So this will most likely be rejected upstream. We could use teeworlds-community to keep supporting the deprecated editor and also add new features. It should not really conflict with upstream because the upstream somewhat promised to not touch that code.

On the other hand adding new features increases complexity, compile times and increases the risk of bugs. Is that something we want in a code base that should serve as a stable foundation for modders?

@tempral
Copy link
Collaborator

tempral commented Apr 8, 2024

this is a small change, I don't see how it can put at risk the robustness of the project

@ChillerDragon
Copy link
Member

this is a small change, I don't see how it can put at risk the robustness of the project

Yes this specific change seems stable. I was speaking in general. If we decide to maintain the editor v1 we might as well actively add features but not sure if we should aim for that.

@jtbx
Copy link
Collaborator

jtbx commented Apr 9, 2024 via email

@ChillerDragon
Copy link
Member

I rebased the pr on latest community so the pipeline can pass. The pr moved to #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants