Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scroll scoreboard(64 players) #3240 #94

Open
wants to merge 3 commits into
base: community
Choose a base branch
from

Conversation

teeworlds-mirror
Copy link
Collaborator

@ChillerDragon
Copy link
Member

The current scoreboard is really bad and we should address that in teeworlds-community. But I personally am #TeamNoPages

Copy link
Collaborator

@Bamcane Bamcane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to fix a bug

@BlaiZephyr BlaiZephyr enabled auto-merge March 28, 2024 11:30
@Bamcane Bamcane self-requested a review April 4, 2024 10:01
Bamcane
Bamcane previously approved these changes Apr 4, 2024
Copy link
Collaborator

@Bamcane Bamcane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK now

@BlaiZephyr
Copy link
Collaborator

i personally dont like the use of w as the actual scrollkey - a few friends of mine and me included have that key bound for something else already (most commonly used as free-view from what i can tell) - should we really hardcode it to a key that is commonly bound to something else already? - i also wonder if this interferes if the key is already bound to something else

Copy link
Collaborator

@Robyt3 Robyt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I and probably many other players use w to jump so that's probably not a good hotkey to pick for this.

I don't like the static scrolling either, it's not great to follow entries with your eyes. If we want something to scroll it should be smooth scrolling like all scrollregions and listboxes.

@Bamcane
Copy link
Collaborator

Bamcane commented May 1, 2024

I and probably many other players use w to jump so that's probably not a good hotkey to pick for this.

I don't like the static scrolling either, it's not great to follow entries with your eyes. If we want something to scroll it should be smooth scrolling like all scrollregions and listboxes.

For the first problem:
That's just a default key w that you could bind it to another keys, so i think this is not a big problem so far.

For the second problem:
Maybe we could make it to a list, so that we could scroll it more smoothly. To do this, i will update the code in 5 days (Maybe later).

@BlaiZephyr BlaiZephyr disabled auto-merge July 1, 2024 11:35
@Bamcane
Copy link
Collaborator

Bamcane commented Aug 20, 2024

I had a better idea that we should keep pressing the key, then use mouse to scroll it.
So does anyone use the key 'mouse3'?

@BlaiZephyr
Copy link
Collaborator

pressing the mousewheel while Scrolling feels weird IMPO, But it could Work i guess

@BlaiZephyr
Copy link
Collaborator

You pulled latest so you now have a 2K Line diff btw :P

@ChillerDragon
Copy link
Member

You pulled latest so you now have a 2K Line diff btw :P

This is a pr upstream so it should be on the latest change. I just updated the community fork so the diff is now gone (#119).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants