fix: avoid out of memory when minting large files #346
Conversation
|
…ile, the message still reads 'No file selected' which confuses visitors
Zir0h
changed the title
|
You are on fire ❤️! |
melMass
added
the
🫡 Priority: High
|
I'm getting
For a 5Gb file. As I'm looking into it it seems that chrome for instance has an ArrayBuffer size limit of 2GB... So we need to chunk it somehow 😓 |
Good thing we limited minting to 2GB 🤣 |
|
Oops! But with a 1.5GB I get this without errors in the console though
|
|
Ohhh ok there was just a delay between the time it catched the first one to then display the cover... For large file there should probably be some kind of loader to indicate that |
|
In any case not related to this PR, it works! |
I agree 100%! But I'm not good with frontend stuff 😆 |
There was a problem hiding this comment.
Perfect!
In a next PR we should probably:
- check the size of the file and alert about that
- Add some kind of load state after selecting the main mint file, as the UI Isn't blocked one can click submit which fails the validation, not a big deal since once loaded the button for the cover appears and the mint state is restored
* fix: re-enable preview for interactive objkts, regression from #346 * avoid mixed content by providing the fullpath with trailing / * fix width/height --------- Co-authored-by: Mel Massadian <[email protected]>
I tried to fix the out of memory bug from #280 with the suggestion @melMass posted. I don't know if I implemented it correctly tough. It seems to work as expected.