-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SSL params for Auth #430
Conversation
for more information, see https://pre-commit.ci
@domi4484 DatabaseConfig does not accept overridden env variables from QGIS. How could we alter that? |
@cymed I am not sure what do you mean. At this place you have the possibility to pass things from the "QGIS world": https://github.com/teksi/wastewater/blob/main/plugin/teksi_wastewater/teksi_wastewater_plugin.py#L614 Otherwise the modifications here looks correct to me, is it something that still doesn't work? |
My main problem is handling of the user name. ili2pg requires a username even if the username is implicitly passed using certs. Currently, I implemented the OS user as a fallback, but there might be situations where the pg username is distinct from the OS username. |
for more information, see https://pre-commit.ci
I guess you should be able to access it like that, but this needs to be done inside teksi_wastewater_plugin.py and passed to the DBUtils class
|
for more information, see https://pre-commit.ci
@cymed Fine for me, ili2db remains an issue but won't be fixed here right? Free to merge. |
sslmode works, but ili2db and QGIS require different cert types. Once thst is fixed upstream, we need no adaptations |
is fixed or has to be fixed upstream, because I saw your issue is still open on ili2pg? |
The upstream issue stems from the type of ssl certificate only. Once it is fixed upstream, the TEKSI code is already ready. |
This PR aims to fix the problems in #393. Now. all parameters in the pg_service entry are evaluated by the plugin. When using INTERLIS-Import/Export, all values that are not host/port/database/user/password are stored in a temporary dbparams file for usage in ili2pg.
The main problem I have now is that that SSL-keys must be in DER format to be used in ili2pg, but QGIS requires PEM. Everything except INTERLIS works with SSL. See claeis/ili2db#551 for upstream issue