-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add First StepAction git-clone
to the catalog
#1235
Conversation
f1a8116
to
e940e62
Compare
/test pull-tekton-catalog-integration-tests |
a849ad4
to
7d16aec
Compare
/hold wait for tektoncd/community#1137 to get merged. |
65cb6c3
to
bca7726
Compare
/retest |
/hold cancel |
301b09f
to
4ea5d36
Compare
Catlin Output
|
4ea5d36
to
f3a8eb0
Compare
Catlin Output
|
Catlin Output
|
a341e22
to
b8d35be
Compare
Catlin Output
|
Catlin Output
|
Catlin Output
|
Catlin Output
|
Catlin Output
|
Catlin Output
|
/hold |
421e11d
to
f0a8e69
Compare
Catlin Output
|
This PR adds a first StepAction `git-clone` to the catalog. It is based off the Task but with samples and tests updated.
f0a8e69
to
71be55f
Compare
/hold cancel |
/assign @vinamra28 @vdemeester |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
apiVersion: tekton.dev/v1alpha1 | ||
kind: StepAction | ||
metadata: | ||
name: git-clone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tektoncd/hub-maintainers should we add support for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @piyush-garg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR sets up the tests for StepActions and adds a first StepAction
git-clone
to the catalog.It is based off the Task but with samples and tests updated.
This PR addresses the update to TEP and Issue #1218.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>
. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide for more details.
/kind feature