-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Jib Gradle test failing on IBM Power and Z #1308
base: main
Are you sure you want to change the base?
Conversation
Hi @Sachin-Itagi. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vinamra28 @vdemeester , It seems like the |
7f9764c
to
22161da
Compare
New changes are detected. LGTM label has been removed. |
Catlin Output
Catlin script lint Output
|
/retest |
1 similar comment
/retest |
hi @Sachin-Itagi, I can see that there are 4 versions of this task, should we deprecate the first two and probably maintain 0.3 and 0.4 ? This way we can reduce the future blast radius. WDYT? |
Hi @vinamra28, Sure, That works for me. however I am not entirely sure if the previous two versions won't be needed in the future. |
22161da
to
a36a46e
Compare
Catlin Output
Catlin script lint Output
|
hi @Sachin-Itagi, sure. Let's take this in follow-up MR. |
@Sachin-Itagi: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@vinamra28 The integration test seems to be failing because of the following |
sure @Sachin-Itagi, let me take a look 👨🏻💻 |
a36a46e
to
0e168b2
Compare
Catlin Output
Catlin script lint Output
|
/retest |
@Sachin-Itagi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Changes
Adds a Patch command to upgrade the Jib Gradle Plugin for IBM Power and Z.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>
. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide for more details.