Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Jib Gradle test failing on IBM Power and Z #1308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sachin-Itagi
Copy link
Contributor

@Sachin-Itagi Sachin-Itagi commented Dec 5, 2024

Changes

Adds a Patch command to upgrade the Jib Gradle Plugin for IBM Power and Z.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2024
@tekton-robot
Copy link

Hi @Sachin-Itagi. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2024
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2024
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vdemeester,vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sachin-Itagi
Copy link
Contributor Author

@vinamra28 @vdemeester , It seems like the pull-tekton-catalog-integration-tests is failing with the same error(jib-gradle test is failing) as observed on IBM Power/Z. Should I make the changes directly to the jib-gradle tasks rather than patching for P/Z.

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@tekton-robot
Copy link

New changes are detected. LGTM label has been removed.

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2024
@tekton-robot
Copy link

Catlin Output
FILE: task/jib-gradle/0.1/jib-gradle.yaml
WARN : Step "build-and-push" uses image "gcr.io/cloud-builders/gradle@sha256:797c9936cf33fc30d82a54437541d7ea7f7825c93e3237a89d254b9bc40b0898"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/jib-gradle/0.2/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.3/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.4/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
Catlin script lint Output
WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 15:
      }" > $HOME/init-script.gradle
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      }" > "$HOME"/init-script.gradle


In jib-gradle-build-and-push line 20:
  --init-script=$HOME/init-script.gradle \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --init-script="$HOME"/init-script.gradle \


In jib-gradle-build-and-push line 21:
  --gradle-user-home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --gradle-user-home="$HOME"/.gradle \


In jib-gradle-build-and-push line 22:
  -Dgradle.user.home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Dgradle.user.home="$HOME"/.gradle \


In jib-gradle-build-and-push line 23:
  -Duser.home=$HOME \
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Duser.home="$HOME" \


In jib-gradle-build-and-push line 24:
  -Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
                                ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 25:
  -Djib.to.image=$(params.IMAGE) \
                 ^-------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 26:
  -Djib.outputPaths.digest=$(workspaces.source.path)/$(params.DIRECTORY)/image-digest
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 28:
echo $(params.IMAGE) | tee $(results.IMAGE_URL.path)
     ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
     ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@Sachin-Itagi
Copy link
Contributor Author

/retest

1 similar comment
@Sachin-Itagi
Copy link
Contributor Author

/retest

@vinamra28
Copy link
Member

hi @Sachin-Itagi, I can see that there are 4 versions of this task, should we deprecate the first two and probably maintain 0.3 and 0.4 ? This way we can reduce the future blast radius. WDYT?

@Sachin-Itagi
Copy link
Contributor Author

Hi @vinamra28, Sure, That works for me. however I am not entirely sure if the previous two versions won't be needed in the future.

@tekton-robot
Copy link

Catlin Output
FILE: task/jib-gradle/0.1/jib-gradle.yaml
WARN : Step "build-and-push" uses image "gcr.io/cloud-builders/gradle@sha256:797c9936cf33fc30d82a54437541d7ea7f7825c93e3237a89d254b9bc40b0898"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/jib-gradle/0.2/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.3/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.4/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
Catlin script lint Output
WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 15:
      }" > $HOME/init-script.gradle
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      }" > "$HOME"/init-script.gradle


In jib-gradle-build-and-push line 20:
  --init-script=$HOME/init-script.gradle \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --init-script="$HOME"/init-script.gradle \


In jib-gradle-build-and-push line 21:
  --gradle-user-home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --gradle-user-home="$HOME"/.gradle \


In jib-gradle-build-and-push line 22:
  -Dgradle.user.home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Dgradle.user.home="$HOME"/.gradle \


In jib-gradle-build-and-push line 23:
  -Duser.home=$HOME \
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Duser.home="$HOME" \


In jib-gradle-build-and-push line 24:
  -Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
                                ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 25:
  -Djib.to.image=$(params.IMAGE) \
                 ^-------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 26:
  -Djib.outputPaths.digest=$(workspaces.source.path)/$(params.DIRECTORY)/image-digest
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 28:
echo $(params.IMAGE) | tee $(results.IMAGE_URL.path)
     ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
     ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@vinamra28
Copy link
Member

Hi @vinamra28, Sure, That works for me. however I am not entirely sure if the previous two versions won't be needed in the future.

hi @Sachin-Itagi, sure. Let's take this in follow-up MR.

@tekton-robot
Copy link

@Sachin-Itagi: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-tekton-catalog-build-tests
  • /test pull-tekton-catalog-integration-tests
  • /test pull-tekton-catalog-unit-tests

Use /test all to run all jobs.

In response to this:

/retest pull-tekton-catalog-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sachin-Itagi
Copy link
Contributor Author

/retest

@Sachin-Itagi
Copy link
Contributor Author

@vinamra28 The integration test seems to be failing because of the following redhat-dependency-analytics/0-2 task. This is blocking the merge. Can you please take a look at it. Thanks.

@vinamra28
Copy link
Member

@vinamra28 The integration test seems to be failing because of the following redhat-dependency-analytics/0-2 task. This is blocking the merge. Can you please take a look at it. Thanks.

sure @Sachin-Itagi, let me take a look 👨🏻‍💻

@tekton-robot
Copy link

Catlin Output
FILE: task/jib-gradle/0.1/jib-gradle.yaml
WARN : Step "build-and-push" uses image "gcr.io/cloud-builders/gradle@sha256:797c9936cf33fc30d82a54437541d7ea7f7825c93e3237a89d254b9bc40b0898"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/jib-gradle/0.2/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.3/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.4/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
Catlin script lint Output
WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 15:
      }" > $HOME/init-script.gradle
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      }" > "$HOME"/init-script.gradle


In jib-gradle-build-and-push line 20:
  --init-script=$HOME/init-script.gradle \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --init-script="$HOME"/init-script.gradle \


In jib-gradle-build-and-push line 21:
  --gradle-user-home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --gradle-user-home="$HOME"/.gradle \


In jib-gradle-build-and-push line 22:
  -Dgradle.user.home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Dgradle.user.home="$HOME"/.gradle \


In jib-gradle-build-and-push line 23:
  -Duser.home=$HOME \
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Duser.home="$HOME" \


In jib-gradle-build-and-push line 24:
  -Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
                                ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 25:
  -Djib.to.image=$(params.IMAGE) \
                 ^-------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 26:
  -Djib.outputPaths.digest=$(workspaces.source.path)/$(params.DIRECTORY)/image-digest
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 28:
echo $(params.IMAGE) | tee $(results.IMAGE_URL.path)
     ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
     ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@Sachin-Itagi
Copy link
Contributor Author

/retest

@tekton-robot
Copy link

@Sachin-Itagi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-catalog-integration-tests 0e168b2 link true /test pull-tekton-catalog-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants