Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce flakiness in create and edit E2E tests #3621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reduce flakiness in create and edit E2E tests #3621

wants to merge 1 commit into from
+33 −0

Conversation

AlanGreene
Copy link
Member

Changes

Reduce the incidents of flakiness encountered when running the E2E tests locally on some machines. We have not encountered this flakiness in CI, but the changes should have no negative impact.

  • Wait for new page header after navigation. This helps to reduce the likelihood of timeouts when attempting to interact with controls on the destination page
  • Ensure the step details are loaded before making assertions based on the log content

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@AlanGreene
Reduce flakiness in create and edit E2E tests
2b780e7 
Reduce the incidents of flakiness encountered when running the
E2E tests locally on some machines. We have not encountered this
flakiness in CI, but the changes should have no negative impact.

- Wait for new page header after navigation. This helps to reduce
  the likelihood of timeouts when attempting to interact with
  controls on the destination page
- Ensure the step details are loaded before making assertions
  based on the log content
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from alangreene after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlanGreene AlanGreene requested review from LyndseyBu and removed request for skaegi September 19, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson Awaiting requested review from briangleeson

@LyndseyBu LyndseyBu Awaiting requested review from LyndseyBu

Assignees
No one assigned
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanGreene @tekton-robot