Fix StepAction support in Cluster resolver

[AverageMarcus]

Changes

Fix StepAction support in Cluster resolver

Fixes #8381

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix StepAction support in Cluster resolver

[tekton-robot]

Hi @AverageMarcus. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AverageMarcus]

/kind bug

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	69.3%	80.3%	10.9

[afrittoli]

/ok-to-test

[afrittoli]

Thanks!
I'm not too familiar with this section of the codebase, but in principle it looks good to me. I think this qualifies as a feature rather than a bug - the documented support today is for task and pipeline, this adds step action, which makes sense. Would you mind updating the docs as part of this PR? https://github.com/tektoncd/pipeline/blob/main/docs/cluster-resolver.md

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	69.3%	80.3%	10.9

[vdemeester]

Oh waw, how did I miss that 😮‍💨 .
@afrittoli I would consider this as a bug, as it is supposed to be implemented (it's just that this part of the validation was missing 😱 )

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

Oh waw, how did I miss that 😮‍💨 . @afrittoli I would consider this as a bug, as it is supposed to be implemented (it's just that this part of the validation was missing 😱 )

Well it matches the current docs https://github.com/tektoncd/pipeline/blob/main/docs/cluster-resolver.md... but I'm also ok to merge this and update the docs in a separate PR as long as they go out in the same release

[vdemeester]

Oh waw, how did I miss that 😮‍💨 . @afrittoli I would consider this as a bug, as it is supposed to be implemented (it's just that this part of the validation was missing 😱 )

Well it matches the current docs https://github.com/tektoncd/pipeline/blob/main/docs/cluster-resolver.md... but I'm also ok to merge this and update the docs in a separate PR as long as they go out in the same release

oh waw I missed a lot of things 🤦🏼 my PR got merged too quickly 🎃 😓

[vdemeester]

/retest

[AverageMarcus]

I can update the docs too, give me a moment. :)

[AverageMarcus]

I have updated the docs and I've also refactored the PR slightly to make the supported kinds more obvious so they can be easily updated in the future.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	69.3%	80.3%	10.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	69.3%	80.4%	11.1

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	69.3%	80.4%	11.1

[afrittoli]

Thank you!
/lgtm

[vdemeester]

/retest

[vdemeester]

@afrittoli I think we should backport this to 0.65. The reason is that it appears in the changelog of v0.63.0 as a new feature supported, which… doesn't work (hence the initial kind/bug). How does that sound ?

[afrittoli]

Sounds good to me, feel free to change the label back if you prefer. I thought the feature label would give it more prominence in the release notes, but we can highlight it as a bug fix too

[vdemeester]

/kind bug
/cherry-pick release-v0.65.x

[tekton-robot]

@vdemeester: new pull request created: #8387

In response to this:

/kind bug
/cherry-pick release-v0.65.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.