Extract component styles to core #5282
Conversation
epetrow
changed the title
epetrow
force-pushed
the
extract-component-styles
branch
5 times, most recently
from
d7dba3d to
6265b23
Compare
epetrow
force-pushed
the
extract-component-styles
branch
9 times, most recently
from
ce716a6 to
b13c1d1
Compare
epetrow
changed the title
epetrow
force-pushed
the
extract-component-styles
branch
from
b13c1d1 to
f33b7b6
Compare
epetrow
force-pushed
the
extract-component-styles
branch
from
f33b7b6 to
bef60c4
Compare
epetrow
force-pushed
the
extract-component-styles
branch
from
3274f76 to
3652014
Compare
| } | ||
|
|
||
| // RTL | ||
| .k-rtl, |
There was a problem hiding this comment.
This should be scoped to k-tabstrip.
This is fixed in develop, it seems like some of the theme and layout files of the components in this core modules are applied from a stale develop branch, and some recent changes are missing.
We should carefully look at the differences between develop and this branch output styles and update the core module component files accordingly.
|
ab83343 |
| @@ -46,6 +46,8 @@ | |||
| // Spacing | |||
| $_default-spacing: $kendo-spacing, | |||
| $kendo-spacing: $kendo-spacing !default, | |||
| $kendo-use-input-button-width: false !default, | |||
| $kendo-use-input-spinner-width: false !default, | |||
There was a problem hiding this comment.
These input variables seem too out of place to me.
I would suggest moving them to the component variables.
Or define them globally per-theme.
| @@ -88,6 +88,42 @@ $kendo-theme-colors: ( | |||
| ), | |||
| ) !default; | |||
|
|
|||
| @forward "@progress/kendo-theme-core/scss/color-system/_swatch-legacy.scss" with ( | |||
| $kendo-body-bg: $kendo-body-bg, | |||
| $kendo-body-text: $kendo-body-text, | |||
There was a problem hiding this comment.
Is this @forward necessary in Fluent?
And the other themes?
closes: #305