Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developers Tools Page #335

Merged
merged 11 commits into from
Mar 12, 2024
Merged

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Feb 21, 2024

Fixes #103 and #259

Note: All texts need to be approved by @pmjanus before putting them into all translated index files.

Description

This PR improves the interaction with new developers by giving them a better welcome and separating the three available tools each in their own context. Also, each tab can be deeplinked from an external site using the parameter tab.

All the texts were added to the corresponding index following the i18n standard. Also, a lot of checks were introduced in the forms.

Test scenarios

  • Go to this EVM tab on dev page
    • You should be looking the EVM tab where you can send telos to any account on Testnet once a day
    • copy and paste a valid address and press the button send some telos
      • You should be notified if it succeeds.
    • Press the button again
      • You should get an error and be notified

Screenshots

image

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo self-assigned this Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for telos-app-native-staging ready!

Name Link
🔨 Latest commit 9d7742f
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-staging/deploys/65dd2c8799d2520007778d3d
😎 Deploy Preview https://deploy-preview-335--telos-app-native-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Feb 21, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d7742f
Status: ✅  Deploy successful!
Preview URL: https://350183c3.app-telos-native.pages.dev
Branch Preview URL: https://103-improve-testnet-faucet-p.app-telos-native.pages.dev

View logs

@Viterbo Viterbo requested a review from pmjanus February 21, 2024 22:26
@Viterbo Viterbo changed the title WIP Developers Tools Page Feb 21, 2024
@donnyquixotic
Copy link
Contributor

donnyquixotic commented Feb 23, 2024

@Viterbo can you include input validation in this PR? The logic was just merged into the current form:

:rules="[ val => (/^EOS[0-9A-Za-z]{50}$|^PUB_K1_[0-9A-Za-z]{50}$/i.test(val)) || 'Please provide a valid Owner key']"

I tagged you on #259

@Viterbo Viterbo marked this pull request as ready for review February 27, 2024 00:29
pmjanus
pmjanus previously approved these changes Feb 27, 2024
Copy link
Contributor

@pmjanus pmjanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text is approved

@Viterbo Viterbo dismissed pmjanus’s stale review February 27, 2024 16:20

The merge-base changed after approval.

donnyquixotic
donnyquixotic previously approved these changes Mar 12, 2024
@Viterbo Viterbo dismissed donnyquixotic’s stale review March 12, 2024 21:17

The merge-base changed after approval.

@donnyquixotic donnyquixotic merged commit 8a3cb18 into develop Mar 12, 2024
6 checks passed
@donnyquixotic donnyquixotic deleted the 103-improve-testnet-faucet-page branch March 12, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants