You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paginates transaction table by actions, since each row is an action that references a transaction, we will show 10 or whatever number selected of rows per page instead of all actions for a single transaction.
Test scenarios
Verify that block pages are paginating accurately, try blocks around :1289 and newer blocks as well as any blocks you might have knowledge of being special in any way.
Verify filters are working at least as well as in the production release, create a separate issue for any issues found here that are also present in release.
Checklist:
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have cleaned up the code in the areas my change touches
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings
I have removed any unnecessary console messages
I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
I have tested for mobile functionality and responsiveness
I have added appropriate test coverage
I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )
@pmjanus, your solution works flawlessly!!! Good Job !!!
However, I took the opportunity to make some extra improvements.
1 - Now it shows the block number and a loading spinner while the block is still being fetched.
2 - I encountered that many times it fails to fetch the entire block silently giving no feedback to the user so I decided to make a function to retry the fetch transparently for the user with a maximum of 3 tries. Here's a capture of a two-tries case fetching the block successfully on the last try. (See the console)
3 - I added an error text to show feedback when the block couldn't be fetched even after three times.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #860
Description
Paginates transaction table by actions, since each row is an action that references a transaction, we will show 10 or whatever number selected of rows per page instead of all actions for a single transaction.
Test scenarios
Verify that block pages are paginating accurately, try blocks around :1289 and newer blocks as well as any blocks you might have knowledge of being special in any way.
Verify filters are working at least as well as in the production release, create a separate issue for any issues found here that are also present in release.
Checklist: