Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipfs links to use our own ipfs gateway #767

Closed
wants to merge 0 commits into from

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Feb 6, 2024

Fixes #764

Description

Not all the multimedia links come in the image field. This PR changes any ipfs link to use our own gateway, not only the image field.

Mainnet

Broken NFT: https://wallet.telos.net/evm/collectible-details?contract=0x92c747518f0ECc80FAFE058ADa696E5d55832A99&id=3&tab=attributes

Test scenarios

Screenshots

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo self-assigned this Feb 6, 2024
@Viterbo Viterbo linked an issue Feb 6, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit b6b8f70
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/65cd1d95665f8c000852d1f1
😎 Deploy Preview https://deploy-preview-767--wallet-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit b6b8f70
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/65cd1d95c269b900081bd957
😎 Deploy Preview https://deploy-preview-767--wallet-develop-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo changed the title Fix ipfs liks to use our own ipfs gateway Fix ipfs links to use our own ipfs gateway Feb 6, 2024
donnyquixotic
donnyquixotic previously approved these changes Feb 6, 2024
@Viterbo
Copy link
Collaborator Author

Viterbo commented Feb 7, 2024

I just fixed this problem. Thanks @ezra-sg

image

@Viterbo Viterbo requested a review from donnyquixotic February 7, 2024 14:19
@Viterbo Viterbo closed this Feb 14, 2024
@Viterbo Viterbo force-pushed the 764-mp4-nft-artwork-not-showing-correctly branch from 9d4d615 to b6b8f70 Compare February 14, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mp4 NFT artwork not showing correctly
2 participants