-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding deeplinking to transaction history tab on evm wallet #777
Merged
donnyquixotic
merged 9 commits into
develop
from
342-add-ability-to-deeplink-transaction-table-results
Feb 19, 2024
Merged
adding deeplinking to transaction history tab on evm wallet #777
donnyquixotic
merged 9 commits into
develop
from
342-add-ability-to-deeplink-transaction-table-results
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ezra-sg
reviewed
Feb 19, 2024
ezra-sg
reviewed
Feb 19, 2024
ezra-sg
previously approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, works great! just left some cleanup comments
ezra-sg
approved these changes
Feb 19, 2024
donnyquixotic
approved these changes
Feb 19, 2024
donnyquixotic
deleted the
342-add-ability-to-deeplink-transaction-table-results
branch
February 19, 2024 23:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342
Description
Now, the pagination state is embedded directly into the URL, allowing for the sharing of deep links that lead directly to specific pages of results.
Test scenarios
rowsPerPage=5
&page=1
Checklist: