Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding deeplinking to transaction history tab on evm wallet #777

Merged

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Feb 14, 2024

Fixes #342

Description

Now, the pagination state is embedded directly into the URL, allowing for the sharing of deep links that lead directly to specific pages of results.

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo linked an issue Feb 14, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit b9cede2
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/65d3cb0fe370800008f9c9f4
😎 Deploy Preview https://deploy-preview-777--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit b9cede2
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/65d3cb0f0ce3c700089f6282
😎 Deploy Preview https://deploy-preview-777--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo self-assigned this Feb 14, 2024
ezra-sg
ezra-sg previously approved these changes Feb 19, 2024
Copy link
Contributor

@ezra-sg ezra-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works great! just left some cleanup comments

@donnyquixotic donnyquixotic merged commit 5c88cd2 into develop Feb 19, 2024
9 checks passed
@donnyquixotic donnyquixotic deleted the 342-add-ability-to-deeplink-transaction-table-results branch February 19, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to deeplink transaction table results
3 participants