-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#781 | Search bar (part 2) - Add Token Search Results Support #800
#781 | Search bar (part 2) - Add Token Search Results Support #800
Conversation
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @viter_rod, Regarding the search bar on https://deploy-preview-800--testnet-teloscan.netlify.app/, I'd like to propose improving its keyboard navigation. Currently, users must click on search results even for exact matches. Here are two potential approaches:
Additional request:
Could you evaluate the complexity of implementing these features? They would significantly enhance user experience and accessibility. |
Fixes #780, #781, #782, #801
Draft: this PR is completely included in the third and final part: #812
Description
This PR includes the first part and adds support for tokens, NFTs, contracts and blocks to the search bar, following the sort criteria given in the issue #781 description.
Test Scenarios
go to home page
test the following search queries:
resize the browser to a low resolution and make any search
Known issues: the auto-scroll tabs work, but if the category is already in sight it does scroll to a random point (that's a bug to fix and still has no issue for it)