#902 | in low resolutions the switch network component uses the old buttons #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teloscan-stage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-mainnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viterbo
force-pushed
the
902-bug--in-low-resolutions-the-switch-network-component-uses-the-old-buttons
branch
from
04c9584 to
f486c8f
Compare
Viterbo
force-pushed
the
902-bug--in-low-resolutions-the-switch-network-component-uses-the-old-buttons
branch
from
f486c8f to
5e71290
Compare
pmjanus
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
This PR is included in this other PR
Description
This PR fixes not only the low-resolution buttons to switch between networks but also refactors the whole implementation from the original component code to a utils-multichain-specific shared script that incorporates reacting and updating the network parameter. The default value is based on the
NETWORK_EVM_NAMEenvironment variable.Test scenarios
... to be continued