refactor: always clean up sockets

tempestphp · Dec 24, 2024 · 44efff9 · 44efff9
1 parent d08549f
commit 44efff9
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/src/Tempest/Console/src/Components/Interactive/TaskComponent.php b/src/Tempest/Console/src/Components/Interactive/TaskComponent.php
@@ -104,8 +104,10 @@ public function render(Terminal $terminal): Generator
             }
         } finally {
             if ($this->state->isFinished() && $this->processId) {
-                $this->kill();
+                posix_kill($this->processId, SIGTERM);
             }
+
+            $this->cleanupSockets();
         }
     }
 
@@ -124,14 +126,15 @@ private function renderTask(Terminal $terminal, ?string $line = null): string
         );
     }
 
-    private function kill(): void
+    private function cleanupSockets(): void
     {
-        try {
-            posix_kill($this->processId, SIGTERM);
-            @fclose($this->sockets[0]);
-            @fclose($this->sockets[1]);
-        } catch (Throwable) {
+        foreach ($this->sockets as $socket) {
+            if (is_resource($socket)) {
+                @fclose($socket);
+            }
         }
+
+        $this->sockets = [];
     }
 
     private function executeHandler(): void