Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds coverage composer script #66

Merged
merged 14 commits into from
Feb 21, 2024

Conversation

aidan-casey
Copy link
Member

@aidan-casey aidan-casey commented Feb 20, 2024

This PR adds a coverage script to the composer file. As we have a solution in place (Coveralls, Action, etc.) I will update this to include that as a GitHub action.

Related to #58.

@aidan-casey aidan-casey self-assigned this Feb 20, 2024
@aidan-casey aidan-casey added the Stewardship Maintenance of the repository CI/CD scripts, README, etc. label Feb 20, 2024
@brendt
Copy link
Member

brendt commented Feb 21, 2024

Should coverage also run locally? I'm inclined to keep composer qa as is, and have coverage only run on CI.

@brendt
Copy link
Member

brendt commented Feb 21, 2024

I've also approved Coveralls integration FYI

@aidan-casey
Copy link
Member Author

@brendt - For the time being, I will move coverage out to a separate command. I treat it as a "qa" thing locally, since I prefer to know what my coverage is before I commit.

@aidan-casey aidan-casey marked this pull request as ready for review February 21, 2024 15:57
@aidan-casey aidan-casey merged commit ccbdf45 into tempestphp:main Feb 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stewardship Maintenance of the repository CI/CD scripts, README, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants