Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): use document root instead of env in tempest serve #717

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

aazsamir
Copy link
Contributor

This #704 pull request added router for ./tempest serve to correctly handle paths with file extension.

It uses putenv but on default php environment $_ENV is not populated.
It depends on php.ini setting variables_order that often is set to GPCS instead of EGPCS.

But php cli allows to set $_SERVER['DOCUMENT_ROOT'] with -t flag, so we can use it to pass public path to router.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11787190071

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 82.464%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Tempest/Http/src/Commands/router.php 0 1 0.0%
Totals Coverage Status
Change from base Build 11770148738: 0.009%
Covered Lines: 7256
Relevant Lines: 8799

💛 - Coveralls

@innocenzi innocenzi changed the title fix(console): use document root instead of env fix(http): use document root instead of env in tempest serve Nov 12, 2024
@brendt brendt merged commit ccc1ece into tempestphp:main Nov 12, 2024
58 checks passed
@brendt
Copy link
Member

brendt commented Nov 12, 2024

Thanks!

@aazsamir aazsamir deleted the feat/dev-serve-use-document-root branch November 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants