Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): add make:middleware command #804

Merged

Conversation

gturpin-dev
Copy link
Contributor

@gturpin-dev gturpin-dev commented Dec 4, 2024

This PR check a TODO on #759
It add the make:middleware command which have different available types :

  • http
  • console
  • event-bus
  • command-bus

Please tell me if I forgot one ?

Also, could you review the Stubs that I provide, not sure if they fit properly to the common use cases.
I started from the docs examples.

@gturpin-dev gturpin-dev changed the title feat(console): add "make:middleware" command feat(console): add make:middleware command Dec 4, 2024
@innocenzi innocenzi requested a review from brendt December 4, 2024 15:34
@gturpin-dev
Copy link
Contributor Author

Hey @brendt There still some issue with tests as we discussed in Discord, so I think we must wait this to be updated on main before review this one

@gturpin-dev
Copy link
Contributor Author

@brendt Ready to review 🎉

@gturpin-dev gturpin-dev marked this pull request as ready for review December 11, 2024 08:31
@brendt brendt merged commit 467c664 into tempestphp:main Dec 11, 2024
60 checks passed
@brendt
Copy link
Member

brendt commented Dec 11, 2024

Nice! I didn't have anything to add, solid PR 💪

@gturpin-dev gturpin-dev deleted the feat/console/make-middleware-command branch December 16, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants