-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): add make:middleware
command
#804
Merged
brendt
merged 12 commits into
tempestphp:main
from
gturpin-dev:feat/console/make-middleware-command
Dec 11, 2024
Merged
feat(console): add make:middleware
command
#804
brendt
merged 12 commits into
tempestphp:main
from
gturpin-dev:feat/console/make-middleware-command
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gturpin-dev
changed the title
feat(console): add "make:middleware" command
feat(console): add Dec 4, 2024
make:middleware
command
Hey @brendt There still some issue with tests as we discussed in Discord, so I think we must wait this to be updated on |
@brendt Ready to review 🎉 |
Nice! I didn't have anything to add, solid PR 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR check a TODO on #759
It add the
make:middleware
command which have different available types :Please tell me if I forgot one ?
Also, could you review the
Stubs
that I provide, not sure if they fit properly to the common use cases.I started from the docs examples.