fix(http): correct HTTP 418 description and coverage #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackshadev
changed the title
blackshadev
force-pushed
the
fix-april-fools-statuscode
branch
from
5bf5065 to
29651c8
Compare
innocenzi
requested changes
Dec 6, 2024
innocenzi
changed the title
innocenzi
reviewed
Dec 6, 2024
innocenzi
approved these changes
Dec 6, 2024
aidan-casey
added
the
Perfect Storm
|
Thank you, @blackshadev! This was driving me nuts and I'm awarding this the "Perfect Storm" label for adding context. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778 .
Somebody has to fix the most important and widely used HTTP statuscodes out there.
For anybody who doesn't know, 418 is a official HTTP status code introduces as an RFC during april fools by the official networking working committee at that time. I don't know why and how, but it was accepted and it stuck. Recently there was a movement to remove it, but surprise surprise , after more than 10 years not only did people use it. People loved this small easter egg in a rigid spec of the foundation of our internet.
Read the RFC if you have the time, it is a proper laugh.