Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): add task component #857

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

innocenzi
Copy link
Member

@innocenzi innocenzi commented Dec 13, 2024

This pull request adds atask component that shows a spinner and prints the time it took to execute a handler.

EDIT: removed the key/value component, I'm adding it in another PR.

CleanShot.2024-12-13.at.15.57.09.mp4

Note

The task component requires pcntl.
I didn't implement a static component alternative, but someone can definitely PR one.

I don't like that the design is very much the same as Laravel. I was out of inspiration. If you have any ideas, feel free to step in. I'm not even sure it fits with the rest of the current design system. (see next comment)

@innocenzi innocenzi marked this pull request as draft December 13, 2024 15:32
@innocenzi innocenzi changed the title feat(console): add keyValue and task methods feat(console): add keyValue and task methods Dec 13, 2024
@innocenzi
Copy link
Member Author

Design update:

CleanShot.2024-12-15.at.19.15.10.mp4

@innocenzi innocenzi marked this pull request as ready for review December 15, 2024 18:25
@innocenzi
Copy link
Member Author

Ready for review. CI failures seem unrelated

@innocenzi innocenzi force-pushed the feat/console/more-components branch from 4e4735d to 7f09df9 Compare December 16, 2024 21:26
@innocenzi innocenzi changed the title feat(console): add keyValue and task methods feat(console): add task component Dec 16, 2024
@innocenzi innocenzi requested a review from brendt December 18, 2024 14:40
@innocenzi innocenzi force-pushed the feat/console/more-components branch from 23b0fb6 to d08549f Compare December 23, 2024 23:05
@innocenzi innocenzi force-pushed the feat/console/more-components branch 3 times, most recently from eedac03 to 0e82dde Compare December 24, 2024 11:45
@innocenzi innocenzi force-pushed the feat/console/more-components branch from 0e82dde to 53b7b83 Compare December 24, 2024 11:51
@innocenzi
Copy link
Member Author

So, the CI fails on MySQL because "the server has gone away". After investigation, what I think happens is that the connection is duplicated because of pcntl_fork, and it's then being mixed up with the main process.

What we would ideally need to do is close the database connection before forking, but we can't do that yet (see #872). Instead, I'm opting out of database-specific tests for this, since it's unrelated and likely won't affect actual users as it is development commands, not anything that would be used in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants