-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): add task
component
#857
base: main
Are you sure you want to change the base?
feat(console): add task
component
#857
Conversation
keyValue
and task
methods
Design update: CleanShot.2024-12-15.at.19.15.10.mp4 |
Ready for review. CI failures seem unrelated |
4e4735d
to
7f09df9
Compare
keyValue
and task
methodstask
component
23b0fb6
to
d08549f
Compare
eedac03
to
0e82dde
Compare
0e82dde
to
53b7b83
Compare
So, the CI fails on MySQL because "the server has gone away". After investigation, what I think happens is that the connection is duplicated because of What we would ideally need to do is close the database connection before forking, but we can't do that yet (see #872). Instead, I'm opting out of database-specific tests for this, since it's unrelated and likely won't affect actual users as it is development commands, not anything that would be used in production. |
This pull request adds a
task
component that shows a spinner and prints the time it took to execute a handler.EDIT: removed the key/value component, I'm adding it in another PR.
CleanShot.2024-12-13.at.15.57.09.mp4
Note
The task component requires
pcntl
.I didn't implement a static component alternative, but someone can definitely PR one.
I don't like that the design is very much the same as Laravel. I was out of inspiration. If you have any ideas, feel free to step in. I'm not even sure it fits with the rest of the current design system.(see next comment)