Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean up workflow files #860

Merged
merged 6 commits into from
Dec 16, 2024
Merged

ci: clean up workflow files #860

merged 6 commits into from
Dec 16, 2024

Conversation

innocenzi
Copy link
Member

This pull request cleans up workflow files:

  • I made the task names consistent in casing
  • I removed two seemingly unused workflows
  • I fixed coding-conventions.yml, which was corrupted in a rebase
  • I removed the updating of CHANGELOG.md in the GitHub release workflow, as that doesn't work with branch protections
  • I took the opportunity to update package.json scripts

@aidan-casey
Copy link
Member

@innocenzi looks like there are still a few cases of the brand names being off (another phpstan, etc.). Once that's cleaned up, I like it and let's get this merged.

Side note, this is one of those things we should probably document in contributing.

@innocenzi innocenzi merged commit 2e69390 into main Dec 16, 2024
12 checks passed
@innocenzi innocenzi deleted the ci/cleanup branch December 16, 2024 19:40
@innocenzi
Copy link
Member Author

@aidan-casey Thanks! Here I was, thinking I was clever with my perfectionism, and I missed one 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants