Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Artikodin pull request trigger to pull_request_target #5

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

XaF
Copy link
Contributor

@XaF XaF commented Jan 12, 2024

What was changed

This change will allow this workflow to run with secrets even if a pull request is made from a fork.

Why?

The pull_request_target trigger works in the context of the base branch, allowing to give access to secrets even in the context of forks, since this wouldn't run code from the pull request but code from the base branch.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

The `pull_request_target` trigger works in the context of the base branch, allowing to give access to secrets even in the context of forks, since this wouldn't run code from the pull request but code from the base branch.

This change will allow this workflow to run with secrets even if a pull request is made from a fork.
@XaF XaF requested a review from a team as a code owner January 12, 2024 03:04
@XaF XaF requested a review from jackdawm January 12, 2024 03:05
Copy link
Contributor

@jackdawm jackdawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

@jackdawm jackdawm merged commit 7a61520 into main Jan 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants