Fix off-by-one error in fulfillment code #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This fixes an off-by-one error (selection of an array slice omits the final element) in the Activity that creates a fulfillment.
Why?
When submitting an order for two items, I found that there were two fulfillments, as expected. However, I also found that the second one was empty.
Checklist
Closes: N/A
How was this tested:
I tested this manually, observing that the second fulfillment was empty (before the change) and that it contained the expected content (after the change). I hope to create an automated test to validate the desired behavior, but wanted to submit a draft PR with the fix first.
Any docs updates needed?
No