Make all properties in interceptor configs readonly. Activity input: …

…add activity method reflection when possible
temporalio · Oct 18, 2023 · 5ef06ca · 5ef06ca
1 parent 28affbc
commit 5ef06ca
Show file tree

Hide file tree

Showing 27 changed files with 214 additions and 210 deletions.
diff --git a/src/Interceptor/ActivityInbound/ActivityInput.php b/src/Interceptor/ActivityInbound/ActivityInput.php
@@ -9,25 +9,21 @@
 
 namespace Temporal\Interceptor\ActivityInbound;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\DataConverter\ValuesInterface;
 use Temporal\Interceptor\HeaderInterface;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class ActivityInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public ValuesInterface $arguments,
-        #[Immutable]
-        public HeaderInterface $header,
+        public readonly ValuesInterface $arguments,
+        public readonly HeaderInterface $header,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowClient/CancelInput.php b/src/Interceptor/WorkflowClient/CancelInput.php
@@ -9,22 +9,19 @@
 
 namespace Temporal\Interceptor\WorkflowClient;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\Workflow\WorkflowExecution;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class CancelInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public WorkflowExecution $workflowExecution,
+        public readonly WorkflowExecution $workflowExecution,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowClient/GetResultInput.php b/src/Interceptor/WorkflowClient/GetResultInput.php
@@ -9,28 +9,22 @@
 
 namespace Temporal\Interceptor\WorkflowClient;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\Workflow\WorkflowExecution;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class GetResultInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public WorkflowExecution $workflowExecution,
-        #[Immutable]
-        public ?string $workflowType,
-        #[Immutable]
-        public ?int $timeout,
-        #[Immutable]
-        public mixed $type,
+        public readonly WorkflowExecution $workflowExecution,
+        public readonly ?string $workflowType,
+        public readonly ?int $timeout,
+        public readonly mixed $type,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowClient/QueryInput.php b/src/Interceptor/WorkflowClient/QueryInput.php
@@ -9,29 +9,23 @@
 
 namespace Temporal\Interceptor\WorkflowClient;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\DataConverter\ValuesInterface;
 use Temporal\Workflow\WorkflowExecution;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class QueryInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public WorkflowExecution $workflowExecution,
-        #[Immutable]
-        public ?string $workflowType,
-        #[Immutable]
-        public string $queryType,
-        #[Immutable]
-        public ValuesInterface $arguments,
+        public readonly WorkflowExecution $workflowExecution,
+        public readonly ?string $workflowType,
+        public readonly string $queryType,
+        public readonly ValuesInterface $arguments,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowClient/SignalInput.php b/src/Interceptor/WorkflowClient/SignalInput.php
@@ -9,29 +9,23 @@
 
 namespace Temporal\Interceptor\WorkflowClient;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\DataConverter\ValuesInterface;
 use Temporal\Workflow\WorkflowExecution;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class SignalInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public WorkflowExecution $workflowExecution,
-        #[Immutable]
-        public ?string $workflowType,
-        #[Immutable]
-        public string $signalName,
-        #[Immutable]
-        public ValuesInterface $arguments,
+        public readonly WorkflowExecution $workflowExecution,
+        public readonly ?string $workflowType,
+        public readonly string $signalName,
+        public readonly ValuesInterface $arguments,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowClient/SignalWithStartInput.php b/src/Interceptor/WorkflowClient/SignalWithStartInput.php
@@ -9,26 +9,21 @@
 
 namespace Temporal\Interceptor\WorkflowClient;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\DataConverter\ValuesInterface;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class SignalWithStartInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public StartInput $workflowStartInput,
-        #[Immutable]
-        public string $signalName,
-        #[Immutable]
-        public ValuesInterface $signalArguments,
+        public readonly StartInput $workflowStartInput,
+        public readonly string $signalName,
+        public readonly ValuesInterface $signalArguments,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowClient/StartInput.php b/src/Interceptor/WorkflowClient/StartInput.php
@@ -9,32 +9,25 @@
 
 namespace Temporal\Interceptor\WorkflowClient;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\Client\WorkflowOptions;
 use Temporal\DataConverter\ValuesInterface;
 use Temporal\Interceptor\HeaderInterface;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class StartInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public string $workflowId,
-        #[Immutable]
-        public string $workflowType,
-        #[Immutable]
-        public HeaderInterface $header,
-        #[Immutable]
-        public ValuesInterface $arguments,
-        #[Immutable]
-        public WorkflowOptions $options,
+        public readonly string $workflowId,
+        public readonly string $workflowType,
+        public readonly HeaderInterface $header,
+        public readonly ValuesInterface $arguments,
+        public readonly WorkflowOptions $options,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowClient/TerminateInput.php b/src/Interceptor/WorkflowClient/TerminateInput.php
@@ -9,24 +9,20 @@
 
 namespace Temporal\Interceptor\WorkflowClient;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\Workflow\WorkflowExecution;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class TerminateInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public WorkflowExecution $workflowExecution,
-        #[Immutable]
-        public string $reason,
+        public readonly WorkflowExecution $workflowExecution,
+        public readonly string $reason,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowInbound/QueryInput.php b/src/Interceptor/WorkflowInbound/QueryInput.php
@@ -9,24 +9,20 @@
 
 namespace Temporal\Interceptor\WorkflowInbound;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\DataConverter\ValuesInterface;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class QueryInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public string $queryName,
-        #[Immutable]
-        public ValuesInterface $arguments,
+        public readonly string $queryName,
+        public readonly ValuesInterface $arguments,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowInbound/SignalInput.php b/src/Interceptor/WorkflowInbound/SignalInput.php
@@ -9,30 +9,24 @@
 
 namespace Temporal\Interceptor\WorkflowInbound;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\DataConverter\ValuesInterface;
 use Temporal\Interceptor\HeaderInterface;
 use Temporal\Workflow\WorkflowInfo;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class SignalInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public string $signalName,
-        #[Immutable]
-        public WorkflowInfo $info,
-        #[Immutable]
-        public ValuesInterface $arguments,
-        #[Immutable]
-        public HeaderInterface $header,
+        public readonly string $signalName,
+        public readonly WorkflowInfo $info,
+        public readonly ValuesInterface $arguments,
+        public readonly HeaderInterface $header,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowInbound/WorkflowInput.php b/src/Interceptor/WorkflowInbound/WorkflowInput.php
@@ -9,28 +9,23 @@
 
 namespace Temporal\Interceptor\WorkflowInbound;
 
-use JetBrains\PhpStorm\Immutable;
 use Temporal\DataConverter\ValuesInterface;
 use Temporal\Interceptor\HeaderInterface;
 use Temporal\Workflow\WorkflowInfo;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 class WorkflowInput
 {
     /**
      * @no-named-arguments
      * @internal Don't use the constructor. Use {@see self::with()} instead.
      */
     public function __construct(
-        #[Immutable]
-        public WorkflowInfo $info,
-        #[Immutable]
-        public ValuesInterface $arguments,
-        #[Immutable]
-        public HeaderInterface $header,
+        public readonly WorkflowInfo $info,
+        public readonly ValuesInterface $arguments,
+        public readonly HeaderInterface $header,
     ) {
     }
 

diff --git a/src/Interceptor/WorkflowOutboundCalls/AwaitInput.php b/src/Interceptor/WorkflowOutboundCalls/AwaitInput.php
@@ -4,13 +4,11 @@
 
 namespace Temporal\Interceptor\WorkflowOutboundCalls;
 
-use JetBrains\PhpStorm\Immutable;
 use React\Promise\PromiseInterface;
 
 /**
  * @psalm-immutable
  */
-#[Immutable]
 final class AwaitInput
 {
     /**
@@ -20,8 +18,7 @@ final class AwaitInput
      * @param array<callable|PromiseInterface> $conditions
      */
     public function __construct(
-        #[Immutable]
-        public array $conditions,
+        public readonly array $conditions,
     ) {
     }