Pass through global telemetry tags (#303)

temporalio · Apr 3, 2023 · dbf96fd · dbf96fd
1 parent 4ad2e64
commit dbf96fd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/temporalio/bridge/runtime.py b/temporalio/bridge/runtime.py
@@ -73,3 +73,4 @@ class TelemetryConfig:
     tracing: Optional[TracingConfig]
     logging: Optional[LoggingConfig]
     metrics: Optional[MetricsConfig]
+    global_tags: Mapping[str, str]
diff --git a/temporalio/bridge/src/runtime.rs b/temporalio/bridge/src/runtime.rs
@@ -30,6 +30,7 @@ pub struct TelemetryConfig {
     tracing: Option<TracingConfig>,
     logging: Option<LoggingConfig>,
     metrics: Option<MetricsConfig>,
+    global_tags: Option<HashMap<String, String>>
 }
 
 #[derive(FromPyObject)]
@@ -129,6 +130,9 @@ impl TryFrom<TelemetryConfig> for TelemetryOptions {
                 ));
             });
         }
+        if let Some(v) = conf.global_tags {
+            build.global_tags(v);
+        }
         build
             .build()
             .map_err(|err| PyValueError::new_err(format!("Invalid telemetry config: {}", err)))

diff --git a/temporalio/runtime.py b/temporalio/runtime.py
@@ -5,7 +5,7 @@
 
 from __future__ import annotations
 
-from dataclasses import dataclass
+from dataclasses import dataclass, field
 from datetime import timedelta
 from typing import ClassVar, Mapping, Optional, Union
 
@@ -175,6 +175,9 @@ class TelemetryConfig:
     metrics: Optional[Union[OpenTelemetryConfig, PrometheusConfig]] = None
     """Metrics configuration."""
 
+    global_tags: Mapping[str, str] = field(default_factory=dict)
+    """OTel resource tags to be applied to all metrics and traces"""
+
     def _to_bridge_config(self) -> temporalio.bridge.runtime.TelemetryConfig:
         return temporalio.bridge.runtime.TelemetryConfig(
             tracing=None if not self.tracing else self.tracing._to_bridge_config(),
@@ -189,4 +192,5 @@ def _to_bridge_config(self) -> temporalio.bridge.runtime.TelemetryConfig:
                 if not isinstance(self.metrics, PrometheusConfig)
                 else self.metrics._to_bridge_config(),
             ),
+            global_tags=self.global_tags,
         )