Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More client work #159

Merged
merged 3 commits into from
Sep 13, 2024
Merged

More client work #159

merged 3 commits into from
Sep 13, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Sep 11, 2024 •
edited
Loading

What was changed

  • Add workflow list, count, describe, signal, query, update, cancel, and terminate support
  • Add scaffolding for async activity handle/client, but no impl yet
  • Add full failure conversion, payload codecs, and some conversion tests

There's still a lot of tests to write. I may work on these during the life of the PR.

@cretz cretz requested a review from a team September 11, 2024 22:21
Sushisource
Sushisource approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not review in extreme detail but the additions and structure make good sense to me

@cretz cretz merged commit 83bea60 into temporalio:main Sep 13, 2024
8 checks passed
@cretz cretz deleted the more-client-2 branch September 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cretz @Sushisource