Always use dynamic ports

temporalio · Mar 10, 2023 · 4f0c5a7 · 4f0c5a7
1 parent 5b0d733
commit 4f0c5a7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 32 deletions.
diff --git a/temporal/temporalite/config.go b/temporal/temporalite/config.go
@@ -50,7 +50,6 @@ func newDefaultConfig() (*temporaliteConfig, error) {
 		DatabaseFilePath: filepath.Join(userConfigDir, "temporalite", "db", "default.db"),
 		FrontendPort:     0,
 		MetricsPort:      0,
-		DynamicPorts:     false,
 		Namespaces:       nil,
 		SQLitePragmas:    nil,
 		Logger: log.NewZapLogger(log.BuildZapLogger(log.Config{
@@ -88,24 +87,13 @@ func convertLiteConfig(cfg *temporaliteConfig) *config.Config {
 		sqliteConfig.ConnectAttributes["_"+k] = v
 	}
 
-	var pprofPort int
-	if cfg.DynamicPorts {
-		if cfg.FrontendPort == 0 {
-			cfg.FrontendPort = cfg.portProvider.MustGetFreePort()
-		}
-		if cfg.MetricsPort == 0 {
-			cfg.MetricsPort = cfg.portProvider.MustGetFreePort()
-		}
-		pprofPort = cfg.portProvider.MustGetFreePort()
-	} else {
-		if cfg.FrontendPort == 0 {
-			cfg.FrontendPort = defaultFrontendPort
-		}
-		if cfg.MetricsPort == 0 {
-			cfg.MetricsPort = cfg.FrontendPort + 200
-		}
-		pprofPort = cfg.FrontendPort + 201
+	if cfg.FrontendPort == 0 {
+		cfg.FrontendPort = cfg.portProvider.MustGetFreePort()
+	}
+	if cfg.MetricsPort == 0 {
+		cfg.MetricsPort = cfg.portProvider.MustGetFreePort()
 	}
+	pprofPort := cfg.portProvider.MustGetFreePort()
 
 	baseConfig := cfg.BaseConfig
 	baseConfig.Global.Membership = config.Membership{
@@ -189,12 +177,10 @@ func (cfg *temporaliteConfig) mustGetService(frontendPortOffset int) config.Serv
 	}
 
 	// Assign any open port when configured to use dynamic ports
-	if cfg.DynamicPorts {
-		if frontendPortOffset != 0 {
-			svc.RPC.GRPCPort = cfg.portProvider.MustGetFreePort()
-		}
-		svc.RPC.MembershipPort = cfg.portProvider.MustGetFreePort()
+	if frontendPortOffset != 0 {
+		svc.RPC.GRPCPort = cfg.portProvider.MustGetFreePort()
 	}
+	svc.RPC.MembershipPort = cfg.portProvider.MustGetFreePort()
 
 	// Optionally bind frontend to IPv4 address
 	if frontendPortOffset == 0 && cfg.FrontendIP != "" {

diff --git a/temporal/temporalite/options.go b/temporal/temporalite/options.go
@@ -24,7 +24,6 @@ type temporaliteConfig struct {
 	//
 	// When unspecified, the port will be system-chosen.
 	MetricsPort   int
-	DynamicPorts  bool
 	Namespaces    []string
 	SQLitePragmas map[string]string
 	// Logger overrides the default logger.
@@ -91,13 +90,6 @@ func WithFrontendIP(address string) ServerOption {
 	})
 }
 
-// WithDynamicPorts starts Temporal on system-chosen ports.
-func WithDynamicPorts() Option {
-	return newApplyFuncContainer(func(cfg *temporaliteConfig) {
-		cfg.DynamicPorts = true
-	})
-}
-
 // WithNamespaces registers each namespace on Temporal start.
 func WithNamespaces(namespaces ...string) ServerOption {
 	return newApplyFuncContainer(func(cfg *temporaliteConfig) {

diff --git a/temporal/temporaltest/server.go b/temporal/temporaltest/server.go
@@ -152,7 +152,6 @@ func NewServer(opts ...TestServerOption) *TestServer {
 	ts.serverOptions = append(ts.serverOptions,
 		temporalite.WithNamespaces(ts.defaultTestNamespace),
 		temporalite.WithPersistenceDisabled(),
-		temporalite.WithDynamicPorts(),
 		temporalite.WithLogger(log.NewNoopLogger()),
 		temporalite.WithSearchAttributeCacheDisabled(),
 		// Disable "accept incoming network connections?" prompt on macOS