Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests refactoring #6559

Merged
merged 16 commits into from
Oct 2, 2024
Merged

Functional tests refactoring #6559

merged 16 commits into from
Oct 2, 2024

Conversation

ychebotarev
Copy link
Contributor

@ychebotarev ychebotarev commented Sep 25, 2024 •
edited
Loading

What changed?

  1. Refactor functional tests.
  2. Move all common code into separate module
  3. For every test - create designated test suite.
  4. For every test - create '_test.go" file that is executing the corresponding test suite.
  5. Lots of minor refactoring related to code being messy.

@ychebotarev ychebotarev force-pushed the y_func_tests branch 2 times, most recently from a32e0eb to 529a6df Compare October 1, 2024 16:22
@ychebotarev ychebotarev marked this pull request as ready for review October 2, 2024 23:42
@ychebotarev ychebotarev requested a review from a team as a code owner October 2, 2024 23:42
alexshtin
alexshtin approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@alexshtin alexshtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring, thanks for doing it!

@ychebotarev ychebotarev merged commit 5030b23 into main Oct 2, 2024
46 checks passed
@ychebotarev ychebotarev deleted the y_func_tests branch October 2, 2024 23:44
dnr
dnr reviewed Oct 3, 2024
View reviewed changes
tests/testcore/client.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts #6550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnr dnr dnr left review comments

@alexshtin alexshtin alexshtin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ychebotarev @dnr @alexshtin